Bug 160327

Summary: Add support for Element.getAttributeNames()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, cmarcelo, commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#dom-element-getattributenames
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-07-28 16:26:55 PDT
Add support for Element.getAttributeNames(): - https://dom.spec.whatwg.org/#dom-element-getattributenames Firefox already supports this, Chrome does not yet.
Attachments
Patch (13.69 KB, patch)
2016-07-28 16:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-28 16:43:12 PDT
Created attachment 284836 [details] Patch
WebKit Commit Bot
Comment 2 2016-07-28 18:20:55 PDT
Comment on attachment 284836 [details] Patch Clearing flags on attachment: 284836 Committed r203852: <http://trac.webkit.org/changeset/203852>
WebKit Commit Bot
Comment 3 2016-07-28 18:21:00 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 4 2016-07-28 19:18:45 PDT
Comment on attachment 284836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284836&action=review > Source/WebCore/dom/Element.cpp:505 > + if (!hasAttributes()) > + return attributesVector; Is this an important optimization?
Chris Dumez
Comment 5 2016-07-28 19:52:05 PDT
Comment on attachment 284836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284836&action=review >> Source/WebCore/dom/Element.cpp:505 >> + return attributesVector; > > Is this an important optimization? It has the benefit of checking that elementData is not null or the call to attributesIterator() below would crash.
Note You need to log in before you can comment on or make changes to this bug.