Bug 160326

Summary: Do not set negative rate on AVSampleBufferRenderSynchronizer.
Product: WebKit Reporter: zalan <zalan>
Component: MediaAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

zalan
Reported 2016-07-28 16:19:17 PDT
rdar://problem/27355214
Attachments
Patch (4.50 KB, patch)
2016-07-28 16:33 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (4.57 KB, patch)
2016-07-28 16:34 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Patch (4.60 KB, patch)
2016-07-29 16:13 PDT, zalan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
zalan
Comment 1 2016-07-28 16:33:23 PDT
Created attachment 284833 [details] Patch
zalan
Comment 2 2016-07-28 16:34:28 PDT
Created attachment 284834 [details] Patch
Eric Carlson
Comment 3 2016-07-29 09:38:32 PDT
Comment on attachment 284834 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284834&action=review Thank you Zalan! > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:476 > + m_rate = std::max<double>(rate, 0); Nit: I think a comment about why this is necessary would be helpful because we should support negative rates.
zalan
Comment 4 2016-07-29 16:13:20 PDT
Created attachment 284912 [details] Patch
WebKit Commit Bot
Comment 5 2016-07-29 16:43:09 PDT
Comment on attachment 284912 [details] Patch Clearing flags on attachment: 284912 Committed r203924: <http://trac.webkit.org/changeset/203924>
WebKit Commit Bot
Comment 6 2016-07-29 16:43:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.