Bug 160324

Summary:

ASSERTION FAILED in errorProtoFuncToString() when Error name is a single char string.

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, fpizlo, ggaren, keith_miller, msaboff, rhodovan.u-szeged, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
proposed patch.	keith_miller: review+

Description Mark Lam 2016-07-28 15:57:45 PDT

The issue is that errorProtoFuncToString() is using jsNontrivialString() to generate the error string even when the name string can be a single character string.  This is incorrect.  We should be using jsString() instead.

Comment 1 Mark Lam 2016-07-28 15:58:58 PDT

<rdar://problem/27389572>

Comment 2 Mark Lam 2016-07-28 16:03:03 PDT

Created attachment 284827 [details]
proposed patch.

Comment 3 Keith Miller 2016-07-28 16:06:37 PDT

Comment on attachment 284827 [details]
proposed patch.

r=me.

Comment 4 Mark Lam 2016-07-28 18:25:08 PDT

Thanks for the review.  Landed in r203853: <http://trac.webkit.org/r203853>.

Comment 5 Mark Lam 2016-08-04 17:22:14 PDT

*** Bug 149253 has been marked as a duplicate of this bug. ***