Bug 160307

Summary: Parameter to table.deleteRow() / body.deleteRow() should be mandatory
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, darin, dbates, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://html.spec.whatwg.org/multipage/tables.html#the-table-element
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2016-07-28 12:08:18 PDT 
Parameter to HTMLTableElement.deleteRow() should be mandatory:
- https://html.spec.whatwg.org/multipage/tables.html#the-table-element

Firefox and Chrome agree with the specification.
Comment 2 Chris Dumez 2016-07-28 13:15:11 PDT 
Created attachment 284808 [details]
Patch
Comment 3 WebKit Commit Bot 2016-07-28 13:35:11 PDT 
Comment on attachment 284808 [details]
Patch

Rejecting attachment 284808 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 284808, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 203831 = a89df4adb9c2be0d220746eed2eff456e122ea25
r203832 = b76b93d011d411fd7f44a36a77e1f61802f00078
r203833 = d81978c3d6b3bb76bf06f2e4df46bd670ab5025d
r203834 = be4e87b8c19f642324685165da818ea4b2d7ac09
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/1769260
Comment 4 Chris Dumez 2016-07-28 13:39:16 PDT 
Created attachment 284811 [details]
Patch
Comment 5 WebKit Commit Bot 2016-07-28 14:08:38 PDT 
Comment on attachment 284811 [details]
Patch

Clearing flags on attachment: 284811

Committed r203840: <http://trac.webkit.org/changeset/203840>
Comment 6 WebKit Commit Bot 2016-07-28 14:08:43 PDT 
All reviewed patches have been landed.  Closing bug.