| Summary: | Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.) | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tim Horton <thorton> | ||||||
| Component: | New Bugs | Assignee: | Tim Horton <thorton> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | andersca, bdakin, benjamin, cying, james.savage, sam, simon.fraser | ||||||
| Priority: | P2 | ||||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Tim Horton
2016-07-28 03:11:06 PDT
Created attachment 284768 [details]
Patch
Will write changelog and post for review tomorrow, just wanted to get EWS going. Created attachment 284795 [details]
Patch
Comment on attachment 284795 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284795&action=review > Source/WebKit2/Platform/IPC/Connection.cpp:391 > +std::chrono::milliseconds Connection::timeoutRespectingIgnoreTimeoutsForTesting(std::chrono::milliseconds timeout) const > +{ > + return m_ignoreTimeoutsForTesting ? std::chrono::milliseconds::max() : timeout; > +} I thought we are moving away from std::chrono. (In reply to comment #5) > Comment on attachment 284795 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284795&action=review > > > Source/WebKit2/Platform/IPC/Connection.cpp:391 > > +std::chrono::milliseconds Connection::timeoutRespectingIgnoreTimeoutsForTesting(std::chrono::milliseconds timeout) const > > +{ > > + return m_ignoreTimeoutsForTesting ? std::chrono::milliseconds::max() : timeout; > > +} > > I thought we are moving away from std::chrono. Sure, but this code is full of it still. Comment on attachment 284795 [details]
Patch
+1. My code was assuming message ordering, which is wrong.
|