Bug 160280

Summary: [iOS] Add WKUIDelegate SPI for specifying that an attachment list is from a managed source
Product: WebKit Reporter: Andy Estes <aestes>
Component: New BugsAssignee: Andy Estes <aestes>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, enrica, mitz, sam, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
patch for landing none

Andy Estes
Reported 2016-07-27 17:13:32 PDT
[iOS] Add WKUIDelegate SPI for specifying that an attachment list is from a managed source
Attachments
Patch (5.69 KB, patch)
2016-07-27 17:20 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (5.72 KB, patch)
2016-07-27 17:27 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Patch (6.86 KB, patch)
2016-07-27 18:14 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
patch for landing (7.03 KB, patch)
2016-07-27 18:29 PDT, Andy Estes 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Andy Estes
Comment 1 2016-07-27 17:14:39 PDT
<rdar://problem/27471815>
Andy Estes
Comment 2 2016-07-27 17:20:17 PDT
Created attachment 284745 [details] Patch
Andy Estes
Comment 3 2016-07-27 17:27:26 PDT
Created attachment 284746 [details] Patch
mitz
Comment 4 2016-07-27 17:56:44 PDT
Comment on attachment 284746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284746&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:75 > +- (BOOL)_attachmentListSourceIsManagedForWebView:(WKWebView *)webView WK_API_AVAILABLE(ios(WK_IOS_TBA)); Instead of adding this and always calling two delegate methods, can you add a new method that returns both the array and the boolean, and only call that (if implemented by the delegate)?
Andy Estes
Comment 5 2016-07-27 18:14:27 PDT
Created attachment 284749 [details] Patch
mitz
Comment 6 2016-07-27 18:20:06 PDT
Comment on attachment 284749 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284749&action=review > Source/WebKit2/UIProcess/API/Cocoa/WKUIDelegatePrivate.h:75 > +- (NSArray *)_attachmentListForWebView:(WKWebView *)webView sourceIsManaged:(BOOL *)sourceIsManaged WK_API_AVAILABLE(ios(WK_IOS_TBA)); No space after BOOL.
Andy Estes
Comment 7 2016-07-27 18:29:20 PDT
Created attachment 284751 [details] patch for landing
WebKit Commit Bot
Comment 8 2016-07-27 19:00:26 PDT
Comment on attachment 284751 [details] patch for landing Clearing flags on attachment: 284751 Committed r203809: <http://trac.webkit.org/changeset/203809>
WebKit Commit Bot
Comment 9 2016-07-27 19:00:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.