Bug 160225

Summary: Disable WebCoreNSURLSessionTest on ios-simulator
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: Ryan Haddad <ryanhaddad>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, jer.noble
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Ryan Haddad
Reported 2016-07-26 17:25:16 PDT
Disable API test WebCoreNSURLSessionTest.BasicOperation on ios-simulator
Attachments
Patch (1.37 KB, patch)
2016-07-26 17:31 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (1.18 KB, patch)
2016-07-26 20:43 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Patch (1.18 KB, patch)
2016-07-26 22:38 PDT, Ryan Haddad 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2016-07-26 17:30:25 PDT
<rdar://problem/26433289>
Ryan Haddad
Comment 2 2016-07-26 17:31:41 PDT
Created attachment 284657 [details] Patch
Alexey Proskuryakov
Comment 3 2016-07-26 19:21:12 PDT
Comment on attachment 284657 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284657&action=review > Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:164 > +#endif > > TEST_F(WebCoreNSURLSessionTest, InvalidateEmpty) Is it only the BasicOperation test? I assumed that all WebCoreNSURLSessionTest needed to be disabled.
Ryan Haddad
Comment 4 2016-07-26 20:43:44 PDT
Created attachment 284670 [details] Patch This patch disables all of the WebCoreNSURLSession tests on iOS.
Ryan Haddad
Comment 5 2016-07-26 20:44:55 PDT
(In reply to comment #3) > Comment on attachment 284657 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284657&action=review > > > Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:164 > > +#endif > > > > TEST_F(WebCoreNSURLSessionTest, InvalidateEmpty) > > Is it only the BasicOperation test? I assumed that all > WebCoreNSURLSessionTest needed to be disabled. This was the only one that asserted, but yes, we may as well disable them all. New patch uploaded.
Alexey Proskuryakov
Comment 6 2016-07-26 22:04:27 PDT
The new patch breaks Mac build: /Volumes/Data/EWS/WebKit/Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:139:5: error: unknown type name 'WebCoreNSURLSession'; did you mean 'WebCoreNSURLSessionTest'? WebCoreNSURLSession* session = [[WebCoreNSURLSession alloc] initWithResourceLoader:*loader delegate:delegate delegateQueue:[NSOperationQueue mainQueue]];
Ryan Haddad
Comment 7 2016-07-26 22:38:14 PDT
Created attachment 284675 [details] Patch Patch for EWS
Ryan Haddad
Comment 8 2016-07-27 10:17:03 PDT
Comment on attachment 284675 [details] Patch Clearing flags on attachment: 284675 Committed r203781: <http://trac.webkit.org/changeset/203781>
Ryan Haddad
Comment 9 2016-07-27 10:17:07 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.