Bug 160214

Summary: Align CSSStyleDeclaration with the specification
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, dbates, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-07-26 14:35:54 PDT
Align CSSStyleDeclaration with the specification: - https://drafts.csswg.org/cssom/#the-cssstyledeclaration-interface In particular, the parameters to removeProperty() / item() / getPropertyPriority() should be mandatory. Firefox and Chrome match the specification.
Attachments
Patch (10.55 KB, patch)
2016-07-26 14:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (10.53 KB, patch)
2016-07-26 15:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-26 14:58:56 PDT
Created attachment 284638 [details] Patch
Darin Adler
Comment 2 2016-07-26 15:04:05 PDT
Comment on attachment 284638 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284638&action=review > Source/WebCore/css/CSSStyleDeclaration.idl:35 > + [Custom] CSSValue getPropertyCSSValue(DOMString propertyName); Shouldn’t the return value be CSSValue? with a question mark so it’s clear it’s nullable?
Chris Dumez
Comment 3 2016-07-26 15:07:08 PDT
(In reply to comment #2) > Comment on attachment 284638 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284638&action=review > > > Source/WebCore/css/CSSStyleDeclaration.idl:35 > > + [Custom] CSSValue getPropertyCSSValue(DOMString propertyName); > > Shouldn’t the return value be CSSValue? with a question mark so it’s clear > it’s nullable? Yes indeed. I'll update.
Chris Dumez
Comment 4 2016-07-26 15:08:35 PDT
Created attachment 284639 [details] Patch
WebKit Commit Bot
Comment 5 2016-07-26 15:39:25 PDT
Comment on attachment 284639 [details] Patch Clearing flags on attachment: 284639 Committed r203744: <http://trac.webkit.org/changeset/203744>
WebKit Commit Bot
Comment 6 2016-07-26 15:39:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.