Bug 160210

Summary: Parameters to CSSStyleSheet.insertRule() / deleteRule() should be mandatory
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: CSSAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, darin, dbates, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-07-26 13:46:36 PDT
Parameters to CSSStyleSheet.insertRule() / deleteRule() should be mandatory: - https://drafts.csswg.org/cssom/#cssstylesheet They are mandatory in Firefox. They are mandatory in Chrome except for the second parameter of insertRule() which merely logs a deprecation warning. I propose to match Chrome's behavior to move towards to specification while limiting the risk of breakage.
Attachments
Patch (13.00 KB, patch)
2016-07-26 14:04 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (14.28 KB, patch)
2016-07-26 14:38 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-26 14:04:23 PDT
Created attachment 284628 [details] Patch
Chris Dumez
Comment 2 2016-07-26 14:38:40 PDT
Created attachment 284632 [details] Patch
Chris Dumez
Comment 3 2016-07-26 15:01:33 PDT
Comment on attachment 284632 [details] Patch Clearing flags on attachment: 284632 Committed r203740: <http://trac.webkit.org/changeset/203740>
Chris Dumez
Comment 4 2016-07-26 15:01:37 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.