Bug 160208

Summary:

Occasional crash in WebCore::RenderVTTCue::initializeLayoutParameters

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, esprehn+autocc, glenn, kondapallykalyan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch.	none

Description Eric Carlson 2016-07-26 13:35:57 PDT

From crash logs, it seems that RenderVTTCue::firstChild is sometimes NULL when it should not be. Debug builds ASSERT when this is true, but release builds should not crash.

Comment 1 Eric Carlson 2016-07-26 13:36:31 PDT

rdar://problem/21090897

Comment 2 Eric Carlson 2016-07-26 13:43:43 PDT

Created attachment 284625 [details]
Proposed patch.

Comment 3 Darin Adler 2016-07-26 14:15:13 PDT

Comment on attachment 284625 [details]
Proposed patch.

OK

Comment 4 WebKit Commit Bot 2016-07-26 14:36:31 PDT

Comment on attachment 284625 [details]
Proposed patch.

Clearing flags on attachment: 284625

Committed r203737: <http://trac.webkit.org/changeset/203737>

Comment 5 WebKit Commit Bot 2016-07-26 14:36:35 PDT

All reviewed patches have been landed.  Closing bug.