Bug 160206

Summary: Move ControlStates hashmap to RenderBox.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, glenn, kondapallykalyan, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

alan
Reported 2016-07-26 12:29:44 PDT
RenderBox is the only client.
Attachments
Patch (8.06 KB, patch)
2016-07-26 12:33 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (7.97 KB, patch)
2016-07-26 14:20 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2016-07-26 12:33:06 PDT
Created attachment 284618 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-07-26 13:09:17 PDT
Comment on attachment 284618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284618&action=review > Source/WebCore/platform/ControlStates.h:102 > + RetainPtr<PlatformControlInstance> m_controlInstance { nullptr }; No need for this. > Source/WebCore/rendering/RenderBox.cpp:113 > +static HashMap<const RenderObject*, std::unique_ptr<ControlStates>>& controlStatesRendererMap() Maybe do a using for HashMap<const RenderObject*, std::unique_ptr<ControlStates>> > Source/WebCore/rendering/RenderBox.cpp:180 > + removeControlStatesForRenderer(*this); Maybe we should use a bit to avoid this hash lookup on every RenderBox dtor.
alan
Comment 3 2016-07-26 14:20:24 PDT
Created attachment 284629 [details] Patch
WebKit Commit Bot
Comment 4 2016-07-26 14:50:37 PDT
Comment on attachment 284629 [details] Patch Clearing flags on attachment: 284629 Committed r203738: <http://trac.webkit.org/changeset/203738>
WebKit Commit Bot
Comment 5 2016-07-26 14:50:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.