Bug 160178 – [iPhone] Playing a video on tudou.com plays only sound, no video

• Component: New Bugs
• Status: RESOLVED FIXED

[Myles C. Maxfield]

[iPhone] Playing a video on tudou.com plays only sound, no video

[Myles C. Maxfield]

*** Bug 160176 has been marked as a duplicate of this bug. ***

[Myles C. Maxfield]

Created attachment 284546 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/27535468>

[Eric Carlson]

Comment on attachment 284546 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=284546&action=review

This looks generally fine to me, but you will need to get an official r+ from a WK2 reviewer.

> LayoutTests/media/video-webkit-playsinline.html:22
> +    run('internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(' + requiresPlaysInline + ')');

Nit: I think this would be easier to use if you used a template literal, e.g.: run(`internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(${requiresPlaysInline})`);

> LayoutTests/media/video-webkit-playsinline.html:27
> +    run('video.' + (hasWebkitPlaysInline ? 'set' : 'remove') + 'Attribute("webkit-playsinline", "")');

Ditto: run(`video.${hasWebkitPlaysInline ? 'set' : 'remove'}Attribute("webkit-playsinline", "")`);

[Myles C. Maxfield]

Created attachment 284612 [details]
Patch for committing

[Myles C. Maxfield]

Committed r203752: <http://trac.webkit.org/changeset/203752>