Summary: | [iPhone] Playing a video on tudou.com plays only sound, no video | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Myles C. Maxfield <mmaxfield> | ||||||
Component: | New Bugs | Assignee: | Myles C. Maxfield <mmaxfield> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | dino, eric.carlson, jonlee, mitz, simon.fraser, thorton, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Myles C. Maxfield
2016-07-25 16:45:05 PDT
*** Bug 160176 has been marked as a duplicate of this bug. *** Created attachment 284546 [details]
Patch
Comment on attachment 284546 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284546&action=review This looks generally fine to me, but you will need to get an official r+ from a WK2 reviewer. > LayoutTests/media/video-webkit-playsinline.html:22 > + run('internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(' + requiresPlaysInline + ')'); Nit: I think this would be easier to use if you used a template literal, e.g.: run(`internals.settings.setInlineMediaPlaybackRequiresPlaysInlineAttribute(${requiresPlaysInline})`); > LayoutTests/media/video-webkit-playsinline.html:27 > + run('video.' + (hasWebkitPlaysInline ? 'set' : 'remove') + 'Attribute("webkit-playsinline", "")'); Ditto: run(`video.${hasWebkitPlaysInline ? 'set' : 'remove'}Attribute("webkit-playsinline", "")`); Created attachment 284612 [details]
Patch for committing
Committed r203752: <http://trac.webkit.org/changeset/203752> |