Bug 160171

Summary: AssemblyHelpers should own all of the cell allocation methods
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 160125    
Attachments:
Description Flags
the patch
mark.lam: review-
the patch
none
the patch saam: review+

Filip Pizlo
Reported 2016-07-25 13:11:17 PDT
Patch forthcoming.
Attachments
the patch (17.87 KB, patch)
2016-07-25 13:14 PDT, Filip Pizlo 		mark.lam: review-
DetailsFormatted DiffDiff
the patch (17.89 KB, patch)
2016-07-25 13:26 PDT, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (17.89 KB, patch)
2016-07-25 13:31 PDT, Filip Pizlo 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-07-25 13:14:08 PDT
Created attachment 284518 [details] the patch
Mark Lam
Comment 2 2016-07-25 13:19:16 PDT
Comment on attachment 284518 [details] the patch Please fix the build failures.
Filip Pizlo
Comment 3 2016-07-25 13:26:19 PDT
Created attachment 284520 [details] the patch
Filip Pizlo
Comment 4 2016-07-25 13:31:44 PDT
Created attachment 284521 [details] the patch
Saam Barati
Comment 5 2016-07-25 13:51:03 PDT
Comment on attachment 284521 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=284521&action=review LGTM > Source/JavaScriptCore/jit/JITOpcodes32_64.cpp:176 > + emitAllocateJSObject(resultReg, allocatorReg, TrustedImmPtr(structure), TrustedImmPtr(0), scratchReg, slowCases); Style suggestion: Maybe it's worth giving the storage parameter here a temp name.
Filip Pizlo
Comment 6 2016-07-25 14:05:09 PDT
Landed in https://trac.webkit.org/changeset/203699
Note You need to log in before you can comment on or make changes to this bug.