Bug 160150

Summary: Spilling of constant tmps should make it easier for the spill code optimizer to rematerialize the constant
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, keith_miller, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch
sam: review+
better patch benjamin: review+

Filip Pizlo
Reported 2016-07-24 18:03:36 PDT
When we spill in-place for admitsStack()==true, we prevent rematerialization if that argument doesn't also admit immediates (which it almost certainly won't do). So, we prevent remat. We should fix that.
Attachments
the patch (4.81 KB, patch)
2016-07-24 18:06 PDT, Filip Pizlo 		sam: review+
DetailsFormatted DiffDiff
better patch (5.71 KB, patch)
2016-07-25 10:52 PDT, Filip Pizlo 		benjamin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2016-07-24 18:06:28 PDT
Created attachment 284456 [details] the patch
Filip Pizlo
Comment 2 2016-07-25 10:52:34 PDT
Created attachment 284501 [details] better patch Needs to be reviewed again.
Benjamin Poulain
Comment 3 2016-07-25 17:20:34 PDT
Comment on attachment 284501 [details] better patch Why not.
Filip Pizlo
Comment 4 2016-08-23 13:47:13 PDT
Finally landed in http://trac.webkit.org/changeset/204857
Note You need to log in before you can comment on or make changes to this bug.