Bug 160093

Summary:

Web Inspector: Hiding a column which contains a TimelineRuler as the headerview, doesn't hide the headerView

Product:

WebKit

Reporter:

Johan K. Jensen <jj>

Component:

Web Inspector

Assignee:

Matt Baker <mattbaker>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

All

OS:

All

Attachments:

Description	Flags
[Patch] Proposed Fix	none

Description Johan K. Jensen 2016-07-22 12:40:05 PDT

Summary:
Hiding a column (in a DataGrid) which contains a TimelineRuler as the headerview, doesn't hide the TimelineRuler when the column gets hidden. (This is the case for the patch in 160061)

Comment 1 Radar WebKit Bug Importer 2016-07-22 12:40:18 PDT

<rdar://problem/27499300>

Comment 2 Matt Baker 2016-07-22 12:48:14 PDT

This doesn't affect any grids yet, but will become an issue once the Network waterfall column exists. The bug can still be reproduced, by making a small change to OverviewTimelineView:

1. Add the following to OverviewTimelineView's constructor:
   this._dataGrid.columnChooserEnabled = true;
2. Right click the grid header
3. Uncheck the "undefined" column
  => Graph column is hidden but ruler is still visible

Comment 3 Matt Baker 2016-07-22 12:56:04 PDT

Created attachment 284363 [details]
[Patch] Proposed Fix

Comment 4 Joseph Pecoraro 2016-07-28 13:46:44 PDT

Comment on attachment 284363 [details]
[Patch] Proposed Fix

r=me

Comment 5 WebKit Commit Bot 2016-07-28 14:53:05 PDT

Comment on attachment 284363 [details]
[Patch] Proposed Fix

Clearing flags on attachment: 284363

Committed r203844: <http://trac.webkit.org/changeset/203844>

Comment 6 WebKit Commit Bot 2016-07-28 14:53:09 PDT

All reviewed patches have been landed.  Closing bug.