Bug 160050

Summary: Make parameters to Document.getElementsBy*() operations mandatory
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#interface-document
See Also: https://bugs.webkit.org/show_bug.cgi?id=160060
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-07-21 14:38:12 PDT
Make parameters to Document.getElementsBy*() operations mandatory to match the specification: - https://dom.spec.whatwg.org/#interface-document Firefox and Chrome agree with the specification so the compatibility risk should be low. It makes very little sense to call these operations without parameter, especially considering WebKit uses the string "undefined" if the parameter is omitted.
Attachments
Patch (24.86 KB, patch)
2016-07-21 16:04 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-21 16:04:40 PDT
Created attachment 284276 [details] Patch
WebKit Commit Bot
Comment 2 2016-07-21 16:53:34 PDT
Comment on attachment 284276 [details] Patch Clearing flags on attachment: 284276 Committed r203539: <http://trac.webkit.org/changeset/203539>
WebKit Commit Bot
Comment 3 2016-07-21 16:53:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.