Bug 160049 – Web Inspector: Remove unused code from Debounce layout test

• Component: Web Inspector
• Status: RESOLVED FIXED

[Matt Baker]

The Cancel Debounce test case doesn't need to use callCount or startTime.

[Radar WebKit Bug Importer]

<rdar://problem/27479713>

[Radar WebKit Bug Importer]

<rdar://problem/27479718>

[Matt Baker]

Created attachment 284261 [details]
[Patch] Proposed Fix

[Joseph Pecoraro]

Comment on attachment 284261 [details]
[Patch] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=284261&action=review

r=me! I could swear I had these review comments on the original!

> LayoutTests/inspector/unit-tests/debounce.html:132
> -            object.debounce(100).test(1, 'xyz');
> +            object.debounce(100).test();
>              object.test.cancelDebounce();
>  
>              setTimeout(() => { InspectorTest.pass("Debounced function canceled."); resolve(); }, 200);

It would be great to reduce these timeouts. 100 and 200 are very high for tests which typically run in 1-2 ms outside of LayoutTests/inspector.

Want to change them to like 10 and 50?

[Matt Baker]

Created attachment 284365 [details]
[Patch] For Landing

[WebKit Commit Bot]

Comment on attachment 284365 [details]
[Patch] For Landing

Clearing flags on attachment: 284365

Committed r203614: <http://trac.webkit.org/changeset/203614>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.