Bug 160047

Summary: Make parameters mandatory for Document.create*() operations
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: DOMAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, commit-queue, darin, dbates, esprehn+autocc, kangil.han, kondapallykalyan, rniwa, sam
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://dom.spec.whatwg.org/#interface-document
Bug Depends on: 160187    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews102 for mac-yosemite
none
Archive of layout-test-results from ews116 for mac-yosemite
none
Patch none

Chris Dumez
Reported 2016-07-21 13:42:03 PDT
Make parameters mandatory for Document.create*() operations: createTextNode(), createComment(), createCDataSection(), createAttribute() and createProcessingInstruction(). This matches the specification: - https://dom.spec.whatwg.org/#interface-document Firefox and Chrome both agree with the specification so the compatibility risk should be low. Also WebKit uses the string "undefined" when the parameter is omitted, which is not very helpful.
Attachments
Patch (34.76 KB, patch)
2016-07-21 14:22 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews102 for mac-yosemite (806.10 KB, application/zip)
2016-07-21 15:11 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews116 for mac-yosemite (1.44 MB, application/zip)
2016-07-21 15:24 PDT, Build Bot 		no flags
Details
Patch (38.40 KB, patch)
2016-07-21 15:57 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-21 14:22:46 PDT
Created attachment 284259 [details] Patch
Build Bot
Comment 2 2016-07-21 15:11:07 PDT
Comment on attachment 284259 [details] Patch Attachment 284259 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1727973 New failing tests: platform/mac/fast/dom/wrapper-classes-objc.html
Build Bot
Comment 3 2016-07-21 15:11:13 PDT
Created attachment 284265 [details] Archive of layout-test-results from ews102 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 4 2016-07-21 15:24:46 PDT
Comment on attachment 284259 [details] Patch Attachment 284259 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1727991 New failing tests: platform/mac/fast/dom/wrapper-classes-objc.html
Build Bot
Comment 5 2016-07-21 15:24:50 PDT
Created attachment 284268 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Chris Dumez
Comment 6 2016-07-21 15:57:03 PDT
Created attachment 284274 [details] Patch
Chris Dumez
Comment 7 2016-07-21 15:57:53 PDT
Comment on attachment 284274 [details] Patch Clearing flags on attachment: 284274 Committed r203535: <http://trac.webkit.org/changeset/203535>
Chris Dumez
Comment 8 2016-07-21 15:57:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.