Bug 160037

Summary:

Fix null handling for HTMLIFrameElement.marginWidth / marginHeight

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

DOM

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, commit-queue, darin, dbates, esprehn+autocc, gyuyoung.kim, kondapallykalyan, rniwa, sam

Priority:

Keywords:

WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

URL:

https://html.spec.whatwg.org/#HTMLIFrameElement-partial

See Also:

https://bugs.webkit.org/show_bug.cgi?id=159987

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews125 for ios-simulator-wk2	none
Patch	none

Chris Dumez

Reported 2016-07-21 11:58:13 PDT

Fix null handling for HTMLIFrameElement.marginWidth / marginHeight to match the specification: - https://html.spec.whatwg.org/#HTMLIFrameElement-partial We are supposed to treat null as the empty string. Both Firefox and Chrome agree with the specification.

Attachments
Patch (7.81 KB, patch) 2016-07-21 12:27 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (789.24 KB, application/zip) 2016-07-21 13:25 PDT, Build Bot	no flags	Details
Patch (10.12 KB, patch) 2016-07-21 13:27 PDT, Chris Dumez	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-07-21 12:27:28 PDT

Created attachment 284244 [details] Patch

Build Bot

Comment 2 2016-07-21 13:25:32 PDT

Comment on attachment 284244 [details] Patch Attachment 284244 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1727168 New failing tests: imported/w3c/web-platform-tests/html/dom/reflection-embedded.html

Build Bot

Comment 3 2016-07-21 13:25:36 PDT

Created attachment 284253 [details] Archive of layout-test-results from ews125 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5

Chris Dumez

Comment 4 2016-07-21 13:27:45 PDT

Created attachment 284254 [details] Patch

Chris Dumez

Comment 5 2016-07-21 14:11:35 PDT

Comment on attachment 284254 [details] Patch Clearing flags on attachment: 284254 Committed r203524: <http://trac.webkit.org/changeset/203524>

Chris Dumez

Comment 6 2016-07-21 14:11:40 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.