Bug 160025

Summary:

Fix null handling of SVGAngle/SVGLength.valueAsString attribute

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

SVG

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, darin, dbates, dino, rniwa, sabouhallawa, sam, zimmermann

Priority:

Keywords:

WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	rniwa: review+, rniwa: commit-queue-

Chris Dumez

Reported 2016-07-21 08:50:52 PDT

Fix null handling of SVGAngle.valueAsString attribute to match the specification: - https://www.w3.org/TR/SVG/types.html#__svg__SVGAngle__valueAsString - https://www.w3.org/TR/SVG2/types.html#InterfaceSVGAngle We should not treat null as the empty String.

Attachments
Patch (9.08 KB, patch) 2016-07-21 10:09 PDT, Chris Dumez	rniwa: review+ rniwa: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Chris Dumez

Comment 1 2016-07-21 10:09:22 PDT

Ryosuke Niwa

Comment 2 2016-07-21 14:30:10 PDT

Comment on attachment 284223 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284223&action=review > Source/WebCore/ChangeLog:21 > + instead of being ignored. The compatbility risk should be Nit: *compatibility*.

Chris Dumez

Comment 3 2016-07-21 14:32:17 PDT

Note You need to log in before you can comment on or make changes to this bug.