Bug 159984

Summary: Get rid of custom bindings code for XMLHttpRequest.open()
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, cdumez, commit-queue, darin, dbates, esprehn+autocc, kondapallykalyan, rniwa
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
URL: https://xhr.spec.whatwg.org/#xmlhttprequest
Attachments:
Description Flags
Patch none

Chris Dumez
Reported 2016-07-20 13:46:22 PDT
Get rid of custom bindings code for XMLHttpRequest.open() as the bindings generator is able to generate it. Relevant specification: - https://xhr.spec.whatwg.org/#xmlhttprequest The issue is that legacy content prevents treating the 'async' argument being undefined identical from it being omitted. However, this can be achieved by using overloading in IDL, like in the specification.
Attachments
Patch (7.29 KB, patch)
2016-07-20 14:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-20 14:08:11 PDT
Created attachment 284147 [details] Patch
Chris Dumez
Comment 2 2016-07-20 15:04:35 PDT
Comment on attachment 284147 [details] Patch Clearing flags on attachment: 284147 Committed r203470: <http://trac.webkit.org/changeset/203470>
Chris Dumez
Comment 3 2016-07-20 15:04:40 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.