Bug 159966

Summary: Mark overriden methods in WebCore/svg final classes as final
Product: WebKit Reporter: Rawinder Singh <rawinder.webkit>
Component: New BugsAssignee: Rawinder Singh <rawinder.webkit>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, darin, mcatanzaro, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Rawinder Singh
Reported 2016-07-20 01:12:49 PDT
Update WebCore/svg classes so that overriden methods in final classes are marked final.
Attachments
Patch (102.78 KB, patch)
2016-07-20 01:18 PDT, Rawinder Singh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Rawinder Singh
Comment 1 2016-07-20 01:18:25 PDT
Created attachment 284092 [details] Patch
Michael Catanzaro
Comment 2 2016-07-20 14:00:56 PDT
Comment on attachment 284092 [details] Patch I really prefer the override keyword; the semantics are identical in a final class, and override is more clear. But this is what the style guide says to do, so guess I'd better get used to it.
WebKit Commit Bot
Comment 3 2016-07-20 14:22:19 PDT
Comment on attachment 284092 [details] Patch Clearing flags on attachment: 284092 Committed r203469: <http://trac.webkit.org/changeset/203469>
WebKit Commit Bot
Comment 4 2016-07-20 14:22:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.