Bug 159952

Summary: REGRESSION(r203415): ASSERTION FAILED: !m_layoutRoot->container() || !m_layoutRoot->container()->needsLayout()
Product: WebKit Reporter: Ryan Haddad <ryanhaddad>
Component: New BugsAssignee: zalan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Crashlog
none
Patch none

Ryan Haddad
Reported 2016-07-19 14:20:57 PDT
Created attachment 284051 [details] Crashlog ASSERTION FAILED: !m_layoutRoot->container() || !m_layoutRoot->container()->needsLayout() Encountered with LayoutTest editing/pasteboard/drag-drop-input-in-svg.svg Link to failing test run: https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r203415%20(6688)/results.html
Attachments
Crashlog (107.80 KB, text/plain)
2016-07-19 14:20 PDT, Ryan Haddad 		no flags
Details
Patch (2.99 KB, patch)
2016-07-19 15:24 PDT, zalan 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryan Haddad
Comment 1 2016-07-19 14:23:55 PDT
First seen with https://trac.webkit.org/changeset/203415
Ryan Haddad
Comment 2 2016-07-19 14:29:55 PDT
Encountered on both El Capitan and Yosemite Debug WK2
zalan
Comment 3 2016-07-19 15:00:11 PDT
I just need to change the ASSERT to reflect the new behavior. It does not impact functionality.
zalan
Comment 4 2016-07-19 15:24:04 PDT
Created attachment 284061 [details] Patch
Simon Fraser (smfr)
Comment 5 2016-07-19 15:36:43 PDT
Comment on attachment 284061 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284061&action=review > Source/WebCore/ChangeLog:10 > + Update ASSERTs to reflect new functionality, that is, now we can end up in a state > + where the container (RenderView) of one of the dirty subtrees is dirty. > + See r203415. Can these go away if we fix FrameSelection to not call renderView->setNeedsLayout()? If so, you should track that cleanup in a bug.
WebKit Commit Bot
Comment 6 2016-07-19 15:51:06 PDT
Comment on attachment 284061 [details] Patch Clearing flags on attachment: 284061 Committed r203425: <http://trac.webkit.org/changeset/203425>
WebKit Commit Bot
Comment 7 2016-07-19 15:51:09 PDT
All reviewed patches have been landed. Closing bug.
zalan
Comment 8 2016-07-20 10:36:41 PDT
(In reply to comment #5) > Comment on attachment 284061 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=284061&action=review > > > Source/WebCore/ChangeLog:10 > > + Update ASSERTs to reflect new functionality, that is, now we can end up in a state > > + where the container (RenderView) of one of the dirty subtrees is dirty. > > + See r203415. > > Can these go away if we fix FrameSelection to not call > renderView->setNeedsLayout()? If so, you should track that cleanup in a bug. bug 159976
Radar WebKit Bug Importer
Comment 9 2016-07-22 00:01:40 PDT
<rdar://problem/27488703>
Note You need to log in before you can comment on or make changes to this bug.