Bug 159948

Summary: REGRESSION(202927): The first slide is the only displayed slide when Quicklooking a Keynote file
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
simon.fraser: review+
Patch
none
Patch none

Dean Jackson
Reported 2016-07-19 13:54:39 PDT
REGRESSION(202927): The first slide is the only displayed slide when Quicklooking a Keynote file
Attachments
Patch (2.52 KB, patch)
2016-07-19 14:08 PDT, Dean Jackson 		simon.fraser: review+
DetailsFormatted DiffDiff
Patch (3.90 KB, patch)
2016-07-19 15:04 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (4.35 KB, patch)
2016-07-19 15:18 PDT, Dean Jackson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2016-07-19 14:08:28 PDT
Created attachment 284049 [details] Patch
Simon Fraser (smfr)
Comment 2 2016-07-19 14:17:23 PDT
Comment on attachment 284049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284049&action=review > Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:91 > + colorSpace = adoptCF(CGBitmapContextGetColorSpace(cgContext)); > + break; > + case kCGContextTypeIOSurface: > + colorSpace = adoptCF(CGIOSurfaceContextGetColorSpace(cgContext)); > + break; > + default: > + colorSpace = adoptCF(CGContextCopyDeviceColorSpace(cgContext)); Do you need to declare any new SPI for these?
Dean Jackson
Comment 3 2016-07-19 14:57:59 PDT
Comment on attachment 284049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=284049&action=review >> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:91 >> + colorSpace = adoptCF(CGContextCopyDeviceColorSpace(cgContext)); > > Do you need to declare any new SPI for these? Yes. I was waiting for EWS to tell me :)
Dean Jackson
Comment 4 2016-07-19 15:04:48 PDT
Created attachment 284058 [details] Patch
Dean Jackson
Comment 5 2016-07-19 15:18:45 PDT
Created attachment 284060 [details] Patch
Dean Jackson
Comment 6 2016-07-19 15:45:03 PDT
Committed r203424: <http://trac.webkit.org/changeset/203424>
Note You need to log in before you can comment on or make changes to this bug.