Bug 159908

Summary: input.formEnctype / formMethod and button.formEnctype / formMethod / type should treat null as "null"
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: BindingsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, cdumez, commit-queue, darin, dbates, rniwa
Priority: P2 Keywords: WebExposed
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews121 for ios-simulator-wk2
none
Patch
none
Patch none

Chris Dumez
Reported 2016-07-18 16:43:40 PDT
input.formEnctype / formMethod and button.formEnctype / formMethod / type should treat null as "null" String: - https://html.spec.whatwg.org/multipage/forms.html#htmlinputelement - https://html.spec.whatwg.org/multipage/forms.html#htmlbuttonelement In WebKit, we treat null as a null String which ends up removing the corresponding attribute. This does not match the specification. Firefox and Chrome match the specification here.
Attachments
Patch (17.04 KB, patch)
2016-07-18 16:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews121 for ios-simulator-wk2 (911.67 KB, application/zip)
2016-07-18 17:40 PDT, Build Bot 		no flags
Details
Patch (20.27 KB, patch)
2016-07-18 18:19 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (20.26 KB, patch)
2016-07-18 20:32 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-18 16:49:22 PDT
Created attachment 283960 [details] Patch
Build Bot
Comment 2 2016-07-18 17:40:08 PDT
Comment on attachment 283960 [details] Patch Attachment 283960 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1704018 New failing tests: imported/w3c/web-platform-tests/html/dom/reflection-forms.html
Build Bot
Comment 3 2016-07-18 17:40:11 PDT
Created attachment 283966 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5
Chris Dumez
Comment 4 2016-07-18 18:19:10 PDT
Created attachment 283968 [details] Patch
Chris Dumez
Comment 5 2016-07-18 20:32:25 PDT
Created attachment 283974 [details] Patch
WebKit Commit Bot
Comment 6 2016-07-18 21:46:49 PDT
Comment on attachment 283974 [details] Patch Clearing flags on attachment: 283974 Committed r203394: <http://trac.webkit.org/changeset/203394>
WebKit Commit Bot
Comment 7 2016-07-18 21:46:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.