Bug 159908

Summary:

input.formEnctype / formMethod and button.formEnctype / formMethod / type should treat null as "null"

Product:

WebKit

Reporter:

Chris Dumez <cdumez>

Component:

Bindings

Assignee:

Chris Dumez <cdumez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cdumez, commit-queue, darin, dbates, rniwa

Priority:

Keywords:

WebExposed

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews121 for ios-simulator-wk2	none
Patch	none
Patch	none

Description Chris Dumez 2016-07-18 16:43:40 PDT

input.formEnctype / formMethod and button.formEnctype / formMethod / type should treat null as "null" String:
- https://html.spec.whatwg.org/multipage/forms.html#htmlinputelement
- https://html.spec.whatwg.org/multipage/forms.html#htmlbuttonelement

In WebKit, we treat null as a null String which ends up removing the corresponding attribute. This does not match the specification.
Firefox and Chrome match the specification here.

Comment 1 Chris Dumez 2016-07-18 16:49:22 PDT

Created attachment 283960 [details]
Patch

Comment 2 Build Bot 2016-07-18 17:40:08 PDT

Comment on attachment 283960 [details]
Patch

Attachment 283960 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/1704018

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-forms.html

Comment 3 Build Bot 2016-07-18 17:40:11 PDT

Created attachment 283966 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.5

Comment 4 Chris Dumez 2016-07-18 18:19:10 PDT

Created attachment 283968 [details]
Patch

Comment 5 Chris Dumez 2016-07-18 20:32:25 PDT

Created attachment 283974 [details]
Patch

Comment 6 WebKit Commit Bot 2016-07-18 21:46:49 PDT

Comment on attachment 283974 [details]
Patch

Clearing flags on attachment: 283974

Committed r203394: <http://trac.webkit.org/changeset/203394>

Comment 7 WebKit Commit Bot 2016-07-18 21:46:55 PDT

All reviewed patches have been landed.  Closing bug.