Bug 159898

Summary: Clean up float styles for video and image placement
Product: WebKit Reporter: Jon Davis <jond>
Component: WebKit WebsiteAssignee: Jon Davis <jond>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, joepeck, jond, timothy
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Jon Davis
Reported 2016-07-18 13:57:01 PDT
Floating videos need sized to allow for readable text. Special margin treatments are needed for first-line floating elements.
Attachments
Patch (2.79 KB, patch)
2016-07-18 14:00 PDT, Jon Davis 		no flags
DetailsFormatted DiffDiff
Patch (2.29 KB, patch)
2016-07-18 14:05 PDT, Jon Davis 		no flags
DetailsFormatted DiffDiff
Patch (2.44 KB, patch)
2016-07-18 14:56 PDT, Jon Davis 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jon Davis
Comment 1 2016-07-18 14:00:56 PDT
Created attachment 283929 [details] Patch
Jon Davis
Comment 2 2016-07-18 14:05:46 PDT
Created attachment 283931 [details] Patch
Joseph Pecoraro
Comment 3 2016-07-18 14:11:43 PDT
Comment on attachment 283931 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283931&action=review rs=me > Websites/webkit.org/ChangeLog:11 > + (@media only screen and (max-width: 415px)): This seems to be a lie, you could update it to what it actually is, or just drop it. > Websites/webkit.org/ChangeLog:12 > + (#post-4132 pre:nth-child(-n+8)): This is a lie, you can remove this line.
Jon Davis
Comment 4 2016-07-18 14:56:34 PDT
Created attachment 283937 [details] Patch
Benjamin Poulain
Comment 5 2016-07-18 17:53:33 PDT
Comment on attachment 283937 [details] Patch lgtm
Jon Davis
Comment 6 2016-07-19 10:04:22 PDT
Comment on attachment 283937 [details] Patch Thanks!
WebKit Commit Bot
Comment 7 2016-07-19 10:24:55 PDT
Comment on attachment 283937 [details] Patch Clearing flags on attachment: 283937 Committed r203410: <http://trac.webkit.org/changeset/203410>
WebKit Commit Bot
Comment 8 2016-07-19 10:24:59 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.