Summary: | Exceptions logged to the JS console should use toString() | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, darin | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 159822 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Brady Eidson
2016-07-16 12:43:42 PDT
Retitled: Exceptions logged to the JS console should use toString() *** Bug 159845 has been marked as a duplicate of this bug. *** *** Bug 159846 has been marked as a duplicate of this bug. *** When we change this to use toString, I think we possibly want to use a variant of toString that does not run arbitrary code. Created attachment 283866 [details]
Patch
(In reply to comment #4) > When we change this to use toString, I think we possibly want to use a > variant of toString that does not run arbitrary code. Okay. (In reply to comment #6) > (In reply to comment #4) > > When we change this to use toString, I think we possibly want to use a > > variant of toString that does not run arbitrary code. > > Okay. Seems useful to not initialize a "toString" message when the ExceptionBase is made, as it's not always needed. So toString() will still run code, but cache the result. Created attachment 283867 [details]
Patch
Comment on attachment 283867 [details]
Patch
This is fine. When I said not run "arbitrary code", I meant specifically that it should not run arbitrary JavaScript code, not C++ code.
(In reply to comment #9) > Comment on attachment 283867 [details] > Patch > > This is fine. When I said not run "arbitrary code", I meant specifically > that it should not run arbitrary JavaScript code, not C++ code. Ah! Yah, we're definitely fine there. |