Bug 159854

Summary: [JSC] Enable test262 module tests
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, commit-queue, ggaren, keith_miller, mark.lam, msaboff, ossy, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch saam: review+

Yusuke Suzuki
Reported 2016-07-16 11:56:19 PDT
[JSC] Enable test262 module tests
Attachments
Patch (103.76 KB, patch)
2016-07-16 12:06 PDT, Yusuke Suzuki 		no flags
DetailsFormatted DiffDiff
Patch (104.01 KB, patch)
2016-07-16 12:20 PDT, Yusuke Suzuki 		saam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2016-07-16 12:06:52 PDT
Created attachment 283849 [details] Patch
Yusuke Suzuki
Comment 2 2016-07-16 12:20:26 PDT
Created attachment 283850 [details] Patch
Saam Barati
Comment 3 2016-07-16 15:08:42 PDT
Comment on attachment 283850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283850&action=review r=me > Source/JavaScriptCore/jsc.cpp:2073 > + auto checkException = [&](bool isLastFile, bool hasException, JSValue value) { I think it's WebKit style to have a space between ] and ( but it may be worth double checking.
Yusuke Suzuki
Comment 4 2016-07-17 07:37:34 PDT
Comment on attachment 283850 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283850&action=review Thanks! >> Source/JavaScriptCore/jsc.cpp:2073 >> + auto checkException = [&](bool isLastFile, bool hasException, JSValue value) { > > I think it's WebKit style to have a space between ] and ( > but it may be worth double checking. It seems that many lambdas are defined as `[&] (...) {`. So I'll follow that. (Webkit code style guideline says nothing about lambdas. Maybe, it should be updated.)
Yusuke Suzuki
Comment 5 2016-07-17 07:40:08 PDT
Committed r203332: <http://trac.webkit.org/changeset/203332>
Note You need to log in before you can comment on or make changes to this bug.