Bug 159843

Summary: Mac UI process needs to know about element focus and blur, much like iOS
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: WebKit2Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, enrica, mitz, sam, thorton
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
thorton: review+
Patch
none
Patch for EWS none

Beth Dakin
Reported 2016-07-15 16:08:10 PDT
Mac UI process needs to know about element focus and blur, much like iOS rdar://problem/27229504
Attachments
Patch (21.66 KB, patch)
2016-07-15 16:31 PDT, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch (21.61 KB, patch)
2016-07-15 16:33 PDT, Beth Dakin 		thorton: review+
DetailsFormatted DiffDiff
Patch (21.95 KB, patch)
2016-07-15 16:56 PDT, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch for EWS (21.77 KB, patch)
2016-07-15 17:05 PDT, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2016-07-15 16:31:10 PDT
Created attachment 283810 [details] Patch
WebKit Commit Bot
Comment 2 2016-07-15 16:32:26 PDT
Attachment 283810 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/Cocoa/WebViewImpl.h:275: The parameter name "editableElementIsFocused" adds no information, so it should be removed. [readability/parameter_name] [5] ERROR: Source/WebKit2/UIProcess/WebPageProxy.h:1423: The parameter name "editableElementIsFocused" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 3 2016-07-15 16:33:49 PDT
Created attachment 283812 [details] Patch
Tim Horton
Comment 4 2016-07-15 16:41:50 PDT
Comment on attachment 283812 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283812&action=review > Source/WebKit2/UIProcess/mac/PageClientImpl.h:174 > +#if PLATFORM(MAC) This file is already platform(mac)! > Source/WebKit2/UIProcess/mac/PageClientImpl.mm:624 > +#if PLATFORM(MAC) Ditto!
Beth Dakin
Comment 5 2016-07-15 16:56:12 PDT
Created attachment 283815 [details] Patch
Beth Dakin
Comment 6 2016-07-15 17:05:04 PDT
Created attachment 283819 [details] Patch for EWS
Beth Dakin
Comment 7 2016-07-15 17:41:05 PDT
https://trac.webkit.org/changeset/203312
Note You need to log in before you can comment on or make changes to this bug.