Bug 159825

Summary: ScrollView::setHasHorizontalScrollbar / setHasVerticalScrollbar duplicate their logic
Product: WebKit Reporter: Antonio Gomes <tonikitoo>
Component: Layout and RenderingAssignee: Antonio Gomes <tonikitoo>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch v1
none
Patch simon.fraser: review+

Antonio Gomes
Reported 2016-07-15 12:29:17 PDT
I believe we can introduce a method to avoid this. Patch coming..
Attachments
patch v1 (5.91 KB, patch)
2016-07-15 12:34 PDT, Antonio Gomes 		no flags
DetailsFormatted DiffDiff
Patch (5.05 KB, patch)
2016-07-15 12:37 PDT, Antonio Gomes 		simon.fraser: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antonio Gomes
Comment 1 2016-07-15 12:34:33 PDT
Created attachment 283782 [details] patch v1
Antonio Gomes
Comment 2 2016-07-15 12:37:08 PDT
Created attachment 283783 [details] Patch
Simon Fraser (smfr)
Comment 3 2016-07-15 13:06:31 PDT
Comment on attachment 283783 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283783&action=review > Source/WebCore/platform/ScrollView.cpp:121 > + Extra blank line here.
Antonio Gomes
Comment 4 2016-07-15 13:20:45 PDT
(In reply to comment #3) > Comment on attachment 283783 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=283783&action=review > > > Source/WebCore/platform/ScrollView.cpp:121 > > + > > Extra blank line here. Done.
Antonio Gomes
Comment 5 2016-07-15 13:21:12 PDT
Committed r203294: <https://trac.webkit.org/r203294>.
Note You need to log in before you can comment on or make changes to this bug.