Bug 159825

Summary:

ScrollView::setHasHorizontalScrollbar / setHasVerticalScrollbar duplicate their logic

Product:

WebKit

Reporter:

Antonio Gomes <tonikitoo>

Component:

Layout and Rendering

Assignee:

Antonio Gomes <tonikitoo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

simon.fraser

Priority:

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch v1	none
Patch	simon.fraser: review+

Description Antonio Gomes 2016-07-15 12:29:17 PDT

I believe we can introduce a method to avoid this. Patch coming..

Comment 1 Antonio Gomes 2016-07-15 12:34:33 PDT

Created attachment 283782 [details]
patch v1

Comment 2 Antonio Gomes 2016-07-15 12:37:08 PDT

Created attachment 283783 [details]
Patch

Comment 3 Simon Fraser (smfr) 2016-07-15 13:06:31 PDT

Comment on attachment 283783 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283783&action=review

> Source/WebCore/platform/ScrollView.cpp:121
> +

Extra blank line here.

Comment 4 Antonio Gomes 2016-07-15 13:20:45 PDT

(In reply to comment #3)
> Comment on attachment 283783 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=283783&action=review
> 
> > Source/WebCore/platform/ScrollView.cpp:121
> > +
> 
> Extra blank line here.

Done.

Comment 5 Antonio Gomes 2016-07-15 13:21:12 PDT

Committed r203294: <https://trac.webkit.org/r203294>.