Summary: | Use a private property to implement FetchResponse.body getter | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
Component: | WebCore Misc. | Assignee: | youenn fablet <youennf> | ||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||
Severity: | Normal | CC: | achristensen, cgarcia, commit-queue, gyuyoung.kim | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Bug Depends on: | 159921 | ||||||||||||||
Bug Blocks: | 151937, 159804 | ||||||||||||||
Attachments: |
|
Description
youenn fablet
2016-07-15 05:32:45 PDT
Created attachment 283760 [details]
Patch
Created attachment 283762 [details]
Retrying same patch as it works locally
Created attachment 283894 [details]
Retrying same patch as it works locally
Created attachment 284005 [details]
Patch
Attachment 284005 [details] did not pass style-queue:
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:82: [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateHeaderGenerator' [pylint/E0602] [5]
ERROR: Source/JavaScriptCore/Scripts/generate-js-builtins.py:83: [generate_bindings_for_builtins_files] Undefined variable 'BuiltinsSeparateImplementationGenerator' [pylint/E0602] [5]
Total errors found: 2 in 7 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 284005 [details] Patch This looks reasonable to me. Should it be r?, or are we waiting on https://bugs.webkit.org/show_bug.cgi?id=159921 ? (In reply to comment #6) > Comment on attachment 284005 [details] > Patch > > This looks reasonable to me. Should it be r?, or are we waiting on > https://bugs.webkit.org/show_bug.cgi?id=159921 ? I would prefer to wait for bug 159921 so that this patch is solely focused on FetchResponse. Created attachment 284316 [details]
Rebasing
Comment on attachment 284316 [details] Rebasing Clearing flags on attachment: 284316 Committed r203632: <http://trac.webkit.org/changeset/203632> All reviewed patches have been landed. Closing bug. |