Bug 159797

Summary: Return the correct value from Heap::externalMemorySize
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, ggaren, joepeck, keith_miller, kling, mark.lam, mattbaker, msaboff, nvasilyev, saam, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2016-07-14 17:30:41 PDT
Return the correct value from Heap::externalMemorySize. In practice this wasn't noticed because: m_externalMemorySize < m_extraMemorySize < Heap::extraMemorySize() ^ extra, deprecatedExtra, and ArrayBuffers And the difference between m_externalMemorySize and m_extraMemorySize is relatively small. So this didn't cause any issues in the ResourceUsageOverlay / Web Inspector Memory Timeline. Still, we should use the correct value!
Attachments
[PATCH] Proposed Fix (1.50 KB, patch)
2016-07-14 17:34 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-07-14 17:31:23 PDT
<rdar://problem/27362446>
Joseph Pecoraro
Comment 2 2016-07-14 17:34:02 PDT
Created attachment 283716 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2016-07-14 21:59:57 PDT
Comment on attachment 283716 [details] [PATCH] Proposed Fix Clearing flags on attachment: 283716 Committed r203268: <http://trac.webkit.org/changeset/203268>
WebKit Commit Bot
Comment 4 2016-07-14 22:00:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.