Bug 159796

Summary: Move MediaSampleAVFObjC into its own file
Product: WebKit Reporter: George Ruan <gruan>
Component: MediaAssignee: George Ruan <gruan>
Status: RESOLVED FIXED    
Severity: Enhancement CC: commit-queue, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: All   
OS: All   
See Also: https://bugs.webkit.org/show_bug.cgi?id=159836
https://bugs.webkit.org/show_bug.cgi?id=159833
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

George Ruan
Reported 2016-07-14 17:30:17 PDT
In preparation for a feature that uses MediaSampleAVFObjC, but does not need SourceBufferPrivateAVFObjC.
Attachments
Patch (23.19 KB, patch)
2016-07-14 17:56 PDT, George Ruan 		no flags
DetailsFormatted DiffDiff
Patch (23.13 KB, patch)
2016-07-15 09:49 PDT, George Ruan 		no flags
DetailsFormatted DiffDiff
Patch (23.13 KB, patch)
2016-07-18 09:33 PDT, George Ruan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-07-14 17:33:21 PDT
<rdar://problem/27362488>
George Ruan
Comment 2 2016-07-14 17:56:07 PDT
Created attachment 283720 [details] Patch
Eric Carlson
Comment 3 2016-07-14 22:18:30 PDT
Comment on attachment 283720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283720&action=review > Source/WebCore/platform/graphics/avfoundation/MediaSampleAVFObjC.h:26 > +#ifndef MediaSampleAVFObjC_h Not: this should use "#pragma once" instead
Eric Carlson
Comment 4 2016-07-14 22:19:44 PDT
Comment on attachment 283720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283720&action=review >> Source/WebCore/platform/graphics/avfoundation/MediaSampleAVFObjC.h:26 >> +#ifndef MediaSampleAVFObjC_h > > Not: this should use "#pragma once" instead Nit, not Not
George Ruan
Comment 5 2016-07-15 09:49:42 PDT
Created attachment 283767 [details] Patch
George Ruan
Comment 6 2016-07-18 09:33:44 PDT
Created attachment 283910 [details] Patch
WebKit Commit Bot
Comment 7 2016-07-18 12:24:36 PDT
Comment on attachment 283910 [details] Patch Clearing flags on attachment: 283910 Committed r203363: <http://trac.webkit.org/changeset/203363>
WebKit Commit Bot
Comment 8 2016-07-18 12:24:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.