Bug 159793

Summary: Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebCore Misc.Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, darin, kling, koivisto, rniwa, sam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2016-07-14 16:05:19 PDT
Use fastGetAttribute() / setAttributeWithoutSynchronization() when possible, for performance.
Attachments
Patch (93.04 KB, patch)
2016-07-14 16:36 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (91.42 KB, patch)
2016-07-15 14:13 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-07-14 16:28:37 PDT
P.S: We should really rename fastGetAttribute() to getAttributeWithoutSynchronization() at some point.
Chris Dumez
Comment 2 2016-07-14 16:36:13 PDT
Created attachment 283707 [details] Patch
WebKit Commit Bot
Comment 3 2016-07-15 14:11:09 PDT
Comment on attachment 283707 [details] Patch Rejecting attachment 283707 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 283707, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ching file Source/WebKit/win/DOMHTMLClasses.cpp patching file Source/WebKit2/WebProcess/Plugins/PDF/DeprecatedPDFPlugin.mm patching file Source/WebKit2/WebProcess/Plugins/PDF/PDFPlugin.mm patching file Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginAnnotation.mm patching file Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Ryosuke Niwa']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/1687515
Chris Dumez
Comment 4 2016-07-15 14:13:46 PDT
Created attachment 283790 [details] Patch
WebKit Commit Bot
Comment 5 2016-07-15 14:36:31 PDT
Comment on attachment 283790 [details] Patch Clearing flags on attachment: 283790 Committed r203302: <http://trac.webkit.org/changeset/203302>
WebKit Commit Bot
Comment 6 2016-07-15 14:36:36 PDT
All reviewed patches have been landed. Closing bug.
Darin Adler
Comment 7 2016-07-15 15:31:18 PDT
(In reply to comment #1) > P.S: We should really rename fastGetAttribute() to > getAttributeWithoutSynchronization() at some point. Or maybe attributeWithoutSynchronization.
Note You need to log in before you can comment on or make changes to this bug.