Bug 159792

Summary: Use more Refs with WorkQueues
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: REOPENED    
Severity: Normal CC: buildbot, rniwa, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
beidson: review+, buildbot: commit-queue-
Archive of layout-test-results from ews105 for mac-yosemite-wk2
none
Archive of layout-test-results from ews121 for ios-simulator-wk2 none

Alex Christensen
Reported 2016-07-14 15:59:00 PDT
Use more Refs with WorkQueues
Attachments
Patch (15.43 KB, patch)
2016-07-14 15:59 PDT, Alex Christensen 		beidson: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews105 for mac-yosemite-wk2 (541.83 KB, application/zip)
2016-07-14 16:23 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews121 for ios-simulator-wk2 (385.02 KB, application/zip)
2016-07-14 16:29 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-07-14 15:59:17 PDT
Created attachment 283698 [details] Patch
Alex Christensen
Comment 2 2016-07-14 16:05:30 PDT
https://trac.webkit.org/changeset/203248
Ryan Haddad
Comment 3 2016-07-14 16:22:24 PDT
Reverted r203248 for reason: This change causes LayoutTests to crash and exit early Committed r203251: <http://trac.webkit.org/changeset/203251>
Build Bot
Comment 5 2016-07-14 16:23:08 PDT
Comment on attachment 283698 [details] Patch Attachment 283698 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1682437 Number of test failures exceeded the failure limit.
Build Bot
Comment 6 2016-07-14 16:23:11 PDT
Created attachment 283699 [details] Archive of layout-test-results from ews105 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 7 2016-07-14 16:29:45 PDT
Comment on attachment 283698 [details] Patch Attachment 283698 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/1682451 Number of test failures exceeded the failure limit.
Build Bot
Comment 8 2016-07-14 16:29:47 PDT
Created attachment 283704 [details] Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.5
Ryan Haddad
Comment 9 2016-07-14 16:38:42 PDT
On WK1, 200+ API tests failed with this change: https://build.webkit.org/builders/Apple%20El%20Capitan%20Release%20WK1%20(Tests)/builds/7862
Alex Christensen
Comment 10 2016-07-14 17:12:08 PDT
HashMap<something, std::pair<Ref<something>, something>> causes awful problems like this right now.
Note You need to log in before you can comment on or make changes to this bug.