Bug 159785

Summary:

Header guard style should be updated to be "#pragma once"

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

Tools / Tests

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, fred.wang, glenn, joepeck, lforschler, ossy, simon.fraser

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
[PATCH] Proposed Fix	none

Brady Eidson

Reported 2016-07-14 14:43:44 PDT

Header guard style should be updated to be "#pragma once" Updating the guidelines on the website is easy. Not as easy is updating check-webkit-style, which I don't have the time to do ATM.

Attachments
[PATCH] Proposed Fix (15.44 KB, patch) 2016-09-28 17:17 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2016-09-28 17:12:40 PDT

Style guide was updated with bug 162633: <https://trac.webkit.org/changeset/206495> I'll use this to cover check-webkit-style change.

Joseph Pecoraro

Comment 2 2016-09-28 17:17:26 PDT

Created attachment 290149 [details] [PATCH] Proposed Fix

WebKit Commit Bot

Comment 3 2016-10-06 20:28:34 PDT

Comment on attachment 290149 [details] [PATCH] Proposed Fix Clearing flags on attachment: 290149 Committed r206897: <http://trac.webkit.org/changeset/206897>

WebKit Commit Bot

Comment 4 2016-10-06 20:28:38 PDT

All reviewed patches have been landed. Closing bug.

Simon Fraser (smfr)

Comment 5 2016-10-18 15:50:41 PDT

I'm not sure this is helping at this point: ERROR: Source/WebKit/mac/WebView/WebViewPrivate.h:0: Use #pragma once header guard. [build/header_guard] [5] ERROR: Tools/MiniBrowser/mac/BrowserWindowController.h:0: Use #pragma once header guard. [build/header_guard] [5] ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:0: Use #pragma once header guard. [build/header_guard] [5] Bug 163575.

Brady Eidson

Comment 6 2016-10-19 09:15:29 PDT

(In reply to comment #5) > I'm not sure this is helping at this point: > > ERROR: Source/WebKit/mac/WebView/WebViewPrivate.h:0: Use #pragma once > header guard. [build/header_guard] [5] > ERROR: Tools/MiniBrowser/mac/BrowserWindowController.h:0: Use #pragma once > header guard. [build/header_guard] [5] > ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewPrivate.h:0: Use #pragma > once header guard. [build/header_guard] [5] Those examples clearly show a bug in the style-checker script. I'm not sure why the existence of a fixable bug means that the style check is no longer worth it.

Note You need to log in before you can comment on or make changes to this bug.