Summary: | Check whether font is nonnull for GlyphData instead of calling GlyphData::isValid() | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||
Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, cdumez, commit-queue, dbarton, esprehn+autocc, glenn, kondapallykalyan, pvollan | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 159702 | ||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2016-07-14 14:33:16 PDT
Created attachment 283740 [details]
Patch
Comment on attachment 283740 [details]
Patch
I wonder if there is other code that really means "font is non-null and also isValid"? r=me
Comment on attachment 283740 [details] Patch Clearing flags on attachment: 283740 Committed r203280: <http://trac.webkit.org/changeset/203280> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > Comment on attachment 283740 [details] > Patch > > I wonder if there is other code that really means "font is non-null and also > isValid"? r=me Oh, I just saw this comment. As defined in GlyphData, isValid means "font || glyph" which sounds weird for me. So just checking 'font' is stronger... |