Bug 159770

Summary:

Fix the --minimal build fail in InjectedBundle.cpp

Product:

WebKit

Reporter:

Csaba Osztrogonác <ossy>

Component:

New Bugs

Assignee:

Csaba Osztrogonác <ossy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, darin, ossy, rniwa

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Csaba Osztrogonác 2016-07-14 09:11:15 PDT

build-webkit --minimal fails with the following error message:
../../Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:197:9: error: 'RuntimeEnabledFeatures' has not been declared
../../Source/WebKit2/WebProcess/InjectedBundle/InjectedBundle.cpp:200:9: error: 'RuntimeEnabledFeatures' has not been declared

The problem is that RuntimeEnabledFeatures.h is included inside if guards,
but used unconditionally in these lines. I can't see any good reason to
include any header unconditionally, let's remove these guards to fix the build.

Comment 1 Csaba Osztrogonác 2016-07-14 09:14:36 PDT

Created attachment 283651 [details]
Patch

Comment 2 Csaba Osztrogonác 2016-07-15 06:37:25 PDT

note: revealed by http://trac.webkit.org/changeset/202091 :
-#if ENABLE(SHADOW_DOM)
     if (preference == "WebKitShadowDOMEnabled")
         RuntimeEnabledFeatures::sharedFeatures().setShadowDOMEnabled(enabled);
-#endif

Now shadow DOM is used unconditionally and we need 
to include RuntimeEnabledFeatures.h always.

Comment 3 WebKit Commit Bot 2016-07-18 23:50:57 PDT

Comment on attachment 283651 [details]
Patch

Clearing flags on attachment: 283651

Committed r203398: <http://trac.webkit.org/changeset/203398>

Comment 4 WebKit Commit Bot 2016-07-18 23:51:01 PDT

All reviewed patches have been landed.  Closing bug.