Bug 159750

Summary: Modernize WebSocket handle
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2016-07-13 17:17:07 PDT
Modernize WebSocket handle
Attachments
Patch (25.37 KB, patch)
2016-07-13 17:21 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (26.82 KB, patch)
2016-07-13 23:51 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-07-13 17:21:31 PDT
Created attachment 283591 [details] Patch
Brady Eidson
Comment 2 2016-07-13 17:30:03 PDT
Comment on attachment 283591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283591&action=review > Source/WebCore/ChangeLog:9 > + This patch just removes ThreadableWebSocketChannel::InvalidMessage which is never used It's problematic this was never used. Can we do some archeology and find out why? (e.g., was it used at one time, and that use was just dropped inadvertently?)
Alex Christensen
Comment 3 2016-07-13 17:48:29 PDT
InvalidMessage was introduced but not used in https://bugs.webkit.org/show_bug.cgi?id=80356 It was used in https://bugs.webkit.org/show_bug.cgi?id=80103 It was removed sometime.
Alex Christensen
Comment 4 2016-07-13 23:51:29 PDT
Created attachment 283608 [details] Patch
Alex Christensen
Comment 5 2016-07-14 00:06:54 PDT
https://trac.webkit.org/changeset/203217
Note You need to log in before you can comment on or make changes to this bug.