Bug 159745

Summary: Web Inspector: SidebarPanel classes should use View.layout instead of "refresh"
Product: WebKit Reporter: Matt Baker <mattbaker>
Component: Web InspectorAssignee: Matt Baker <mattbaker>
Status: RESOLVED FIXED    
Severity: Normal CC: bburg, commit-queue, joepeck, mattbaker, nvasilyev, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 159787    
Attachments:
Description Flags
[Patch] Proposed Fix none

Matt Baker
Reported 2016-07-13 16:23:09 PDT
Currently sidebars use a refresh/needsRefresh idiom that parallels view's layout/needsLayout. Since sidebars inherit from View, we should clean this up.
Attachments
[Patch] Proposed Fix (14.71 KB, patch)
2016-07-13 16:57 PDT, Matt Baker 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-07-13 16:23:25 PDT
<rdar://problem/27335252>
Matt Baker
Comment 2 2016-07-13 16:57:19 PDT
Created attachment 283588 [details] [Patch] Proposed Fix
WebKit Commit Bot
Comment 3 2016-07-14 16:38:25 PDT
Comment on attachment 283588 [details] [Patch] Proposed Fix Clearing flags on attachment: 283588 Committed r203253: <http://trac.webkit.org/changeset/203253>
WebKit Commit Bot
Comment 4 2016-07-14 16:38:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.