Bug 159730

Summary: Add more candidate tests
Product: WebKit Reporter: Beth Dakin <bdakin>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, lforschler, sam, thorton
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch thorton: review+

Beth Dakin
Reported 2016-07-13 11:54:44 PDT
Add more candidate tests
Attachments
Patch (21.98 KB, patch)
2016-07-13 12:25 PDT, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch (21.58 KB, patch)
2016-07-13 12:30 PDT, Beth Dakin 		no flags
DetailsFormatted DiffDiff
Patch (21.58 KB, patch)
2016-07-13 12:40 PDT, Beth Dakin 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2016-07-13 12:25:25 PDT
Created attachment 283558 [details] Patch
Beth Dakin
Comment 2 2016-07-13 12:30:55 PDT
Created attachment 283559 [details] Patch
WebKit Commit Bot
Comment 3 2016-07-13 12:32:40 PDT
Attachment 283559 [details] did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/mac/CandidateTests.mm:107: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Tools/TestWebKitAPI/Tests/mac/CandidateTests.mm:128: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.
Beth Dakin
Comment 4 2016-07-13 12:40:15 PDT
Created attachment 283560 [details] Patch
Beth Dakin
Comment 5 2016-07-13 13:53:29 PDT
Thanks Tim! https://trac.webkit.org/changeset/203186
Note You need to log in before you can comment on or make changes to this bug.