Bug 159710

Summary: Test WTF.StringViewIterators is crashing since r203119
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, lforschler, mmaxfield
Priority: P2    
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=159609
Attachments:
Description Flags
Patch darin: review+

Carlos Garcia Campos
Reported 2016-07-13 03:53:35 PDT
I think there are two problems in the test case added in r203119. First is that it's testing StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a const reference to the string view member of the deleted CodePoints object.
Attachments
Patch (1.56 KB, patch)
2016-07-13 03:55 PDT, Carlos Garcia Campos 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2016-07-13 03:55:05 PDT
Created attachment 283508 [details] Patch
Myles C. Maxfield
Comment 2 2016-07-13 12:16:59 PDT
Wow... whoops. Thanks so much for fixing this.
Carlos Garcia Campos
Comment 3 2016-07-13 23:18:31 PDT
Committed r203214: <http://trac.webkit.org/changeset/203214>
Note You need to log in before you can comment on or make changes to this bug.