Bug 159705

Summary:

[Fetch API] Request and Response url getter should use URL serialization

Product:

WebKit

Reporter:

youenn fablet <youennf>

Component:

WebCore Misc.

Assignee:

youenn fablet <youennf>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

151937

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description youenn fablet 2016-07-13 01:23:49 PDT

As per fetch spec, urls should be serialized following https://url.spec.whatwg.org/#concept-url-serializer.

Comment 1 youenn fablet 2016-07-13 02:06:21 PDT

Created attachment 283496 [details]
Patch

Comment 2 Alex Christensen 2016-07-13 08:55:31 PDT

Comment on attachment 283496 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=283496&action=review

> Source/WebCore/platform/URL.h:120
> +    bool hasUser()const;
> +    bool hasPassword()const;
> +    bool hasQuery()const;
> +    bool hasFragment() const;

All of these should have spaces before const.

Comment 3 youenn fablet 2016-07-14 02:46:13 PDT

Created attachment 283629 [details]
Patch for landing

Comment 4 WebKit Commit Bot 2016-07-14 03:15:41 PDT

Comment on attachment 283629 [details]
Patch for landing

Clearing flags on attachment: 283629

Committed r203221: <http://trac.webkit.org/changeset/203221>

Comment 5 WebKit Commit Bot 2016-07-14 03:15:46 PDT

All reviewed patches have been landed.  Closing bug.