| Summary: | Remove ENABLE_CSS3_TEXT_LINE_BREAK flag | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
| Component: | New Bugs | Assignee: | Gyuyoung Kim <gyuyoung.kim> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, ossy | ||||||||
| Priority: | P2 | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 89235 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Gyuyoung Kim
2016-07-12 02:00:43 PDT
Created attachment 283400 [details]
Patch
Attachment 283400 [details] did not pass style-queue:
ERROR: Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5]
ERROR: Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5]
ERROR: Source/WebCore/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5]
ERROR: Source/WebKit2/Configurations/FeatureDefines.xcconfig:0: Any changes made to FeatureDefines should be made to all of them (changed file does not match Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig). [featuredefines/equality] [5]
Total errors found: 4 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 283401 [details]
Patch
Comment on attachment 283401 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283401&action=review > Source/JavaScriptCore/ChangeLog:8 > + r144214 only added ENABLE_CSS3_TEXT_LINE_BREAK flag though, there has been no concrete implementation until now. I think it is completed and used unconditionally - https://bugs.webkit.org/show_bug.cgi?id=89235 Comment on attachment 283401 [details]
Patch
rs=me, but please fix the comment before landing.
Created attachment 283402 [details]
Patch for landing
(In reply to comment #4) > Comment on attachment 283401 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=283401&action=review > > > Source/JavaScriptCore/ChangeLog:8 > > + r144214 only added ENABLE_CSS3_TEXT_LINE_BREAK flag though, there has been no concrete implementation until now. > > I think it is completed and used unconditionally - > https://bugs.webkit.org/show_bug.cgi?id=89235 Ah, I missed this bug. Thank you for pointing it out. Fixed the descriptions in ChangeLogs. The commit-queue encountered the following flaky tests while processing attachment 283402 [details]:
The commit-queue is continuing to process your patch.
The commit-queue encountered the following flaky tests while processing attachment 283402 [details]: transitions/default-timing-function.html bug 138901 (author: simon.fraser@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 283402 [details] Patch for landing Clearing flags on attachment: 283402 Committed r203115: <http://trac.webkit.org/changeset/203115> All reviewed patches have been landed. Closing bug. |