Bug 159652

Summary: SVN.create_patch should find svn-create-patch relative to the WebKit root.
Product: WebKit Reporter: Jason Marcell <jmarcell>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: adele, ap, commit-queue, dbates, ddkilzer, ggaren, glenn, jmarcell, lforschler, mcatanzaro, youennf
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dbates: review+

Jason Marcell
Reported 2016-07-11 16:08:21 PDT
SVN.create_patch should find svn-create-patch relative to the WebKit root.
Attachments
Patch (1.91 KB, patch)
2016-07-11 16:10 PDT, Jason Marcell 		dbates: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jason Marcell
Comment 1 2016-07-11 16:10:10 PDT
Created attachment 283360 [details] Patch
Daniel Bates
Comment 2 2016-07-11 16:19:44 PDT
Comment on attachment 283360 [details] Patch r=me
Daniel Bates
Comment 3 2016-07-11 16:20:35 PDT
Comment on attachment 283360 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283360&action=review > Tools/Scripts/webkitpy/common/checkout/scm/svn.py:42 > +from webkitpy.common.webkit_finder import WebKitFinder > from webkitpy.common.memoized import memoized > from webkitpy.common.system.executive import Executive, ScriptError > from webkitpy.common.config.urls import svn_server_host, svn_server_realm Please sort these imports with respect to the UNIX sort command.
Jason Marcell
Comment 4 2016-07-11 17:25:54 PDT
Landed: https://trac.webkit.org/changeset/203095
Note You need to log in before you can comment on or make changes to this bug.