Bug 159592

Summary: Use refs for ResourceLoaders
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: REOPENED    
Severity: Normal CC: buildbot, cdumez, commit-queue, japhet, rniwa, ryanhaddad
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 159642    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from ews100 for mac-yosemite
none
Archive of layout-test-results from ews116 for mac-yosemite
none
Patch
none
Patch
none
Patch cdumez: review+

Alex Christensen
Reported 2016-07-08 17:32:52 PDT
Use refs for ResourceLoaders
Attachments
Patch (26.96 KB, patch)
2016-07-08 17:33 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews100 for mac-yosemite (1.10 MB, application/zip)
2016-07-08 18:34 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews116 for mac-yosemite (1.66 MB, application/zip)
2016-07-08 18:51 PDT, Build Bot 		no flags
Details
Patch (27.01 KB, patch)
2016-07-08 22:40 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (26.68 KB, patch)
2016-07-08 23:10 PDT, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (27.46 KB, patch)
2016-07-09 15:23 PDT, Alex Christensen 		cdumez: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2016-07-08 17:33:43 PDT
Created attachment 283232 [details] Patch
Build Bot
Comment 2 2016-07-08 18:34:38 PDT
Comment on attachment 283232 [details] Patch Attachment 283232 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/1649693 New failing tests: webarchive/loading/cache-expired-subresource.html http/tests/appcache/foreign-fallback.html http/tests/appcache/main-resource-fallback-for-network-error-crash.html http/tests/appcache/fallback.html
Build Bot
Comment 3 2016-07-08 18:34:42 PDT
Created attachment 283235 [details] Archive of layout-test-results from ews100 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 4 2016-07-08 18:51:47 PDT
Comment on attachment 283232 [details] Patch Attachment 283232 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/1649713 New failing tests: webarchive/loading/cache-expired-subresource.html http/tests/appcache/foreign-fallback.html http/tests/appcache/main-resource-fallback-for-network-error-crash.html http/tests/appcache/fallback.html
Build Bot
Comment 5 2016-07-08 18:51:51 PDT
Created attachment 283237 [details] Archive of layout-test-results from ews116 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-yosemite Platform: Mac OS X 10.10.5
Alex Christensen
Comment 6 2016-07-08 22:40:53 PDT
Created attachment 283245 [details] Patch
Alex Christensen
Comment 7 2016-07-08 23:10:35 PDT
Created attachment 283246 [details] Patch
Chris Dumez
Comment 8 2016-07-09 08:19:06 PDT
Does not build on iOS?
Chris Dumez
Comment 9 2016-07-09 08:33:01 PDT
Comment on attachment 283246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=283246&action=review > Source/WebKit/WebCoreSupport/WebResourceLoadScheduler.h:108 > typedef HashMap<String, HostInformation*, StringHash> HostMap; Still using a raw pointer here? It'd be nice to switch to unique_ptr<> since you're modifying this code.
Alex Christensen
Comment 10 2016-07-09 15:23:59 PDT
Created attachment 283269 [details] Patch
Chris Dumez
Comment 11 2016-07-10 09:53:39 PDT
Comment on attachment 283269 [details] Patch r=me
Alex Christensen
Comment 12 2016-07-11 09:02:17 PDT
https://trac.webkit.org/changeset/203064
WebKit Commit Bot
Comment 13 2016-07-11 13:08:58 PDT
Re-opened since this is blocked by bug 159642
Ryan Haddad
Comment 14 2016-07-11 13:12:04 PDT
(In reply to comment #13) > Re-opened since this is blocked by bug 159642 <rdar://problem/27283181>
Note You need to log in before you can comment on or make changes to this bug.