Bug 159584

Summary: Add synthetic click origin to WKNavigationAction
Product: WebKit Reporter: Enrica Casucci <enrica>
Component: WebKit2Assignee: Enrica Casucci <enrica>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, cdumez, cmarcelo, commit-queue, esprehn+autocc, kangil.han, ryanhaddad, sam, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Path thorton: review+

Enrica Casucci
Reported 2016-07-08 16:18:33 PDT
Adding a private property to retrieve the origin of the synthetic click. rdar://problem/25610422
Attachments
Path (61.66 KB, patch)
2016-07-08 16:28 PDT, Enrica Casucci 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Enrica Casucci
Comment 1 2016-07-08 16:28:55 PDT
Created attachment 283215 [details] Path
WebKit Commit Bot
Comment 2 2016-07-08 16:31:25 PDT
Attachment 283215 [details] did not pass style-queue: ERROR: Source/WebCore/platform/PlatformMouseEvent.h:70: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/platform/PlatformMouseEvent.h:78: Wrong number of spaces before statement. (expected: 31) [whitespace/indent] [4] ERROR: Source/WebCore/page/DragController.cpp:108: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebKit/mac/WebView/WebFrame.mm:980: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/MouseEvent.cpp:102: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] ERROR: Source/WebCore/dom/MouseEvent.cpp:111: Wrong number of spaces before statement. (expected: 27) [whitespace/indent] [4] ERROR: Source/WebCore/dom/SimulatedClick.cpp:52: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 7 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.
Tim Horton
Comment 3 2016-07-11 11:23:11 PDT
Windows build error: C:\cygwin\home\buildbot\WebKit\Source\WebKit\win\WebDropSource.cpp(104): error C2440: '<function-style-cast>': cannot convert from 'initializer list' to 'WebCore::PlatformMouseEvent' [C:\cygwin\home\buildbot\WebKit\WebKitBuild\Release\Source\WebKit\WebKit.vcxproj] C:\cygwin\home\buildbot\WebKit\Source\WebKit\win\WebDropSource.cpp(104): note: No constructor could take the source type, or constructor overload resolution was ambiguous
Enrica Casucci
Comment 4 2016-07-11 14:35:41 PDT
Fixed the windows build before landing. Committed revision 203085.
Ryan Haddad
Comment 5 2016-07-11 14:58:48 PDT
(In reply to comment #4) > Fixed the windows build before landing. > Committed revision 203085. This change still appears to have broken the Windows build: https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/79024
Note You need to log in before you can comment on or make changes to this bug.