Bug 159571

Summary: speculateTypedArrayIsNotNeutered has an inverted speculation
Product: WebKit Reporter: Keith Miller <keith_miller>
Component: New BugsAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mark.lam, msaboff, saam
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mark.lam: review+

Keith Miller
Reported 2016-07-08 11:41:33 PDT
speculateTypedArrayIsNotNeutered has an inverted speculation
Attachments
Patch (1.70 KB, patch)
2016-07-08 11:44 PDT, Keith Miller 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2016-07-08 11:44:33 PDT
Created attachment 283185 [details] Patch
Mark Lam
Comment 2 2016-07-08 11:45:51 PDT
Comment on attachment 283185 [details] Patch r=me Got tests?
Keith Miller
Comment 3 2016-07-08 11:46:44 PDT
(In reply to comment #2) > Comment on attachment 283185 [details] > Patch > > r=me > > Got tests? It's already breaking tests on ToT but only if we eagerly FTL.
Mark Lam
Comment 4 2016-07-08 11:47:45 PDT
(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 283185 [details] > > Patch > > > > r=me > > > > Got tests? > > It's already breaking tests on ToT but only if we eagerly FTL. Can you add a comment in the ChangeLog about which tests will break? Why is it not breaking on the test bots? Do we need to change a config on that test?
Keith Miller
Comment 5 2016-07-08 11:49:06 PDT
Committed r202997: <http://trac.webkit.org/changeset/202997>
Keith Miller
Comment 6 2016-07-08 11:51:22 PDT
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Comment on attachment 283185 [details] > > > Patch > > > > > > r=me > > > > > > Got tests? > > > > It's already breaking tests on ToT but only if we eagerly FTL. > > Can you add a comment in the ChangeLog about which tests will break? Why is > it not breaking on the test bots? Do we need to change a config on that > test? I'll make it clearer in the Changelog that there is already a test failing on the bots.
Note You need to log in before you can comment on or make changes to this bug.