Bug 159564

Summary: Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
Product: WebKit Reporter: youenn fablet <youennf>
Component: Tools / TestsAssignee: youenn fablet <youennf>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, bburg, commit-queue, glenn, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

youenn fablet
Reported 2016-07-08 09:35:24 PDT
The option --with-wrapper-files should be changed to --wrappers
Attachments
Patch (1.23 KB, patch)
2016-07-08 09:37 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-07-08 09:37:06 PDT
Created attachment 283173 [details] Patch
youenn fablet
Comment 2 2016-07-08 09:56:03 PDT
I was thinking that bots were running builtin generation tests. But it seems this is not the case, or not with the run-builtins-generator-tests at least. It might be good to add such tests I guess.
Blaze Burg
Comment 3 2016-07-12 10:21:43 PDT
Comment on attachment 283173 [details] Patch r=me
Blaze Burg
Comment 4 2016-07-12 10:22:27 PDT
(In reply to comment #2) > I was thinking that bots were running builtin generation tests. > But it seems this is not the case, or not with the > run-builtins-generator-tests at least. > It might be good to add such tests I guess. They don't. I've asked many times for other random test suites to run with EWS and bots.
youenn fablet
Comment 5 2016-07-12 10:25:03 PDT
(In reply to comment #4) > (In reply to comment #2) > > I was thinking that bots were running builtin generation tests. > > But it seems this is not the case, or not with the > > run-builtins-generator-tests at least. > > It might be good to add such tests I guess. > > They don't. I've asked many times for other random test suites to run with > EWS and bots. I'll prepare a patch for ESW. As of bots, I also requested that, maybe it is just a matter of preparing a patch as well.
youenn fablet
Comment 6 2016-07-12 10:25:09 PDT
(In reply to comment #4) > (In reply to comment #2) > > I was thinking that bots were running builtin generation tests. > > But it seems this is not the case, or not with the > > run-builtins-generator-tests at least. > > It might be good to add such tests I guess. > > They don't. I've asked many times for other random test suites to run with > EWS and bots. I'll prepare a patch for ESW. As of bots, I also requested that, maybe it is just a matter of preparing a patch as well.
WebKit Commit Bot
Comment 7 2016-07-12 10:44:14 PDT
Comment on attachment 283173 [details] Patch Clearing flags on attachment: 283173 Committed r203118: <http://trac.webkit.org/changeset/203118>
WebKit Commit Bot
Comment 8 2016-07-12 10:44:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.