Bug 15951

Summary: REGRESSION: assertion failure in regexp match() when running JS tests
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: JavaScriptCoreAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, ggaren
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Reduction
none
patch sam: review+

Alexey Proskuryakov
Reported 2007-11-12 03:06:02 PST
Running r27689 or r27710 debug build, not sure when this started or which test causes this. Thread 0 Crashed: 0 match(unsigned short const*, unsigned char const*, int, match_data*) + 31087 (pcre_exec.cpp:1878) 1 jsRegExpExecute(JSRegExp const*, unsigned short const*, int, int, int*, int) + 1705 (pcre_exec.cpp:2272) 2 KJS::RegExp::match(KJS::UString const&, int, WTF::OwnArrayPtr<int>*) + 275 (regexp.cpp:105) 3 KJS::RegExpObjectImp::performMatch(KJS::RegExp*, KJS::UString const&, int, int&, int&, int**) + 64 (regexp_object.cpp:305) 4 KJS::StringProtoFuncSearch::callAsFunction(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 395 (string_object.cpp:611) 5 KJS::JSObject::call(KJS::ExecState*, KJS::JSObject*, KJS::List const&) + 220 (object.cpp:95)
Attachments
Reduction (206 bytes, text/plain)
2007-11-12 13:20 PST, Geoffrey Garen 		no flags
Details
patch (4.35 KB, patch)
2007-11-12 14:25 PST, Darin Adler 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2007-11-12 12:26:36 PST
Geoff was showing this to me today. Should be easy to fix.
Geoffrey Garen
Comment 2 2007-11-12 13:20:58 PST
Created attachment 17209 [details] Reduction
Geoffrey Garen
Comment 3 2007-11-12 13:21:28 PST
This ASSERT fires only with > 100 parens. <= 100 parens won't do it.
Darin Adler
Comment 4 2007-11-12 14:25:48 PST
Created attachment 17213 [details] patch
Sam Weinig
Comment 5 2007-11-12 15:33:54 PST
Comment on attachment 17213 [details] patch Looks good. r=me.
Darin Adler
Comment 6 2007-11-12 16:25:26 PST
Committed revision 27733.
Note You need to log in before you can comment on or make changes to this bug.